Hold my Beer (Fix of hi intellligent data lookup in TGUI Who/Staff Who

[blackcrystall]

🆑 BlackCrystalic
fix: No more admin data sended to normal players in who/staff who
/:cl:

[Drulikar]

• Both implementations listing out clients need to skip invisible admins being listed unless its the for admins list. See https://github.com/cmss13-devs/cmss13/pull/6583/files#diff-4da1f7388c33ae5a42dc442cf07f0a6830e02130bfe77927fc9406787d159fb3L178-L181 (you'll have to expand the hidden removed file to see the lines):

		if(CLIENT_IS_STEALTHED(C) && !CLIENT_HAS_RIGHTS(src, R_STEALTH))
			continue
		if(C.admin_holder?.fakekey && !CLIENT_IS_STAFF(src))
			continue

• usr should never be used in a ui_act. Use ui.user instead.
• mobs_ckey should not be holding hard refs to mobs; and should instead hold weakrefs
• Consider a color key for Staff Who-TGUI #6778

[blackcrystall]

Done

[Drulikar]

invismin & stealthed (these are two different things, thus the two different checks I previously mentioned) staff still appear in who for non-admins, and are still counted in the category in staff who. The only effect is invismin removes the entry under the dropdown (stealthed does nothing):

[blackcrystall]

Ok, done, I think thiss is what you mean by that

[Drulikar]

• Currently a moderator cannot view the playing status of players or staff like a host can:
  
  Only non-staff should have the limited views.
• Because of above, that staff member then can't even see themself when they go invisim.
  
  Staff should still always have a staff view. The only escalated permission is that only management can see stealthed and utuilize stealth. Inivismin should only restrict non-staff from seeing them.

[blackcrystall]

Oh my bad, used wrong check for perms

[Drulikar]

All above issues appear to be resolved.

Some of the tgui changes mentioned below are as a result of #6244

[Drulikar]

It would be ideal for this file to be converted to a tsx file, but it is not required.

[Drulikar]

It would be ideal for this file to be converted to a tsx file, but it is not required.

[Drulikar]

Resolve above since you disallow maintainer modification.