Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentor New Player Markers #6860

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Aug 2, 2024

About the pull request

As title, adds a HUD marker mentors can see while ghosted or as SEA to make it easier to identify new players (anyone with less than ten hours in a role)

Red = New to server & role (<10hrs in a role and <25hrs in the server)
Yellow = New to server (<25hrs in server >10hrs in role)
Green = New to role (>25hrs in server <10hrs in role)

Explain why it's good for the game

QOL for mentors, can be difficult to keep track of someone new in a crowd.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑
add: Added new player markers for SEAs/Mentors
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Aug 2, 2024
@realforest2001
Copy link
Member Author

Somehow it unincluded the file

cm13-github added a commit that referenced this pull request Aug 2, 2024
@hislittlecuzingames
Copy link
Contributor

About the pull request

As title, adds a HUD marker mentors can see while ghosted or as SEA to make it easier to identify new players (anyone with less than ten hours in a role)

Red = New to server & role (<10hrs in a role and <25hrs in the server) Yellow = New to server (<25hrs in server >10hrs in role) Green = New to role (>25hrs in server <10hrs in role)

Explain why it's good for the game

QOL for mentors, can be difficult to keep track of someone new in a crowd.

Testing Photographs and Procedure

Screenshots & Videos

Changelog

🆑 add: Added new player markers for SEAs/Mentors /:cl:

Can we get this as a toggle for non mentors?
IE Medics treating people teaching them about fracs and shrap, and sl/ftl wanting to support the new players?

@Randomplayer2or3
Copy link

Being new to role but not new to server should have a green blip like holo-badge instead of a big "new" over their head as the people that might have this can range from actual new people or veterans (something like at least 100 hours+) trying out a role. You should also exclude departmental Heads as they don't really have more things to do outside of OW if they have time to kill.

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites 👍

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Aug 3, 2024
code/modules/gear_presets/_select_equipment.dm Outdated Show resolved Hide resolved
code/datums/mob_hud.dm Show resolved Hide resolved
Comment on lines +854 to +856
GLOBAL_DATUM(hud_icon_new_player_1, /image)
GLOBAL_DATUM(hud_icon_new_player_2, /image)
GLOBAL_DATUM(hud_icon_new_player_3, /image)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use GLOBAL_DATUM_INIT instead of having every human potentially set it up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to make GLOBAL_DATUM_INIT generate an image

code/modules/mob/dead/observer/observer.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/human_defines.dm Outdated Show resolved Hide resolved
code/datums/mob_hud.dm Show resolved Hide resolved
code/modules/admin/verbs/mentorhud.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft August 4, 2024 04:04
@Drulikar
Copy link
Contributor

Drulikar commented Aug 4, 2024

Of note apparently xenos can see them sometimes, but I think this is a larger issue with HUDs. But I don't know. See https://discord.com/channels/150315577943130112/745447048261795890/1269578770331865188

code/__DEFINES/mob_hud.dm Outdated Show resolved Hide resolved
cm13-github added a commit that referenced this pull request Sep 9, 2024
cm13-github added a commit that referenced this pull request Sep 10, 2024
cm13-github added a commit that referenced this pull request Sep 10, 2024
cm13-github added a commit that referenced this pull request Sep 10, 2024
cm13-github added a commit that referenced this pull request Sep 10, 2024
cm13-github added a commit that referenced this pull request Sep 11, 2024
cm13-github added a commit that referenced this pull request Sep 11, 2024
cm13-github added a commit that referenced this pull request Sep 11, 2024
cm13-github added a commit that referenced this pull request Sep 12, 2024
cm13-github added a commit that referenced this pull request Sep 13, 2024
cm13-github added a commit that referenced this pull request Sep 14, 2024
cm13-github added a commit that referenced this pull request Sep 14, 2024
cm13-github added a commit that referenced this pull request Sep 14, 2024
cm13-github added a commit that referenced this pull request Sep 15, 2024
cm13-github added a commit that referenced this pull request Sep 16, 2024
cm13-github added a commit that referenced this pull request Sep 18, 2024
cm13-github added a commit that referenced this pull request Sep 20, 2024
cm13-github added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants