Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IB fixed fun fact #6863

Merged
merged 8 commits into from
Aug 11, 2024
Merged

IB fixed fun fact #6863

merged 8 commits into from
Aug 11, 2024

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Aug 3, 2024

About the pull request

Adds a fun fact for number of times internal bleeding was fixed, similar to the revives fact.

Explain why it's good for the game

I'm not a huge fan of fun facts in general as it sometimes incentivizes bad behavior (such as focusing on revives exclusively and neglecting other duties just because it has a fun fact), but between removing the revives fact or just adding a second medical fact, I went this direction.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: fun fact for internal bleeding fixed
/:cl:

@zzzmike zzzmike marked this pull request as draft August 3, 2024 09:46
@github-actions github-actions bot added the Feature Feature coder badge label Aug 3, 2024
@zzzmike zzzmike marked this pull request as ready for review August 3, 2024 09:56
@Git-Nivrak
Copy link
Contributor

Git-Nivrak commented Aug 3, 2024

Could be cool if instead you made a fun fact for medics comprised of all the activities you can do (defibbing, healing, fixing IBs etc) so people won't focus on one activity

@zzzmike
Copy link
Contributor Author

zzzmike commented Aug 3, 2024

Could be cool if instead you made a fun fact for medics comprised of all the activities you can do (defibbing, healing, fixing IBs etc) so people won't focus on one activity

If you do a PR I will happily close this one

Copy link
Contributor

@kiVts kiVts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kiVts kiVts added this pull request to the merge queue Aug 11, 2024
Merged via the queue into cmss13-devs:master with commit f51377c Aug 11, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 11, 2024
@zzzmike zzzmike deleted the patch-2 branch August 11, 2024 04:56
@Skatuk
Copy link

Skatuk commented Aug 11, 2024

How about instead of fixed IB's, Its how many IB's you've recieved from xeno's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants