Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPP Wall Flag #6925

Merged
merged 1 commit into from
Aug 22, 2024
Merged

UPP Wall Flag #6925

merged 1 commit into from
Aug 22, 2024

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Aug 11, 2024

About the pull request

Adds a medium sized UPP flag sprite to the game for mappers.

Explain why it's good for the game

Good for helping establish an area is under UPP control.

Testing Photographs and Procedure

Screenshot 2024-08-11 20 13 52

Changelog

🆑
add: A medium sized, wall mounted, UPP flag sprite has been added to the game, for mappers to use.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Aug 11, 2024
@Blundir Blundir added the Sprites Approved confirmed no stray pixels label Aug 11, 2024
@Zenith00000
Copy link
Contributor

Zenith00000 commented Aug 11, 2024

I did actually add a very similar flag with Hybrisa as I was making a TWE flag, so I thought I might as well make more. Yours do look a lot nicer though, and mine are fairly low effort. Perhaps you could replace mine with better versions or expand your PR. Either way great stuff.

(The "worn" versions are primarily up for grabs for mappers who want to make some cool inserts if you're wondering, I'm sure they could see some use.)

flags

@Steelpoint
Copy link
Contributor Author

I did actually add a very similar flag with Hybrisa as I was making a TWE flag, so I thought I might as well make more. Yours do look a lot nicer though, and mine are fairly low effort. Perhaps you could replace mine with better versions or expand your PR. Either way great stuff.

(The "worn" versions are primarily up for grabs for mappers who want to make some cool inserts if you're wondering, I'm sure they could see some use.)

flags

If you are adding them with your PR then we all look forward to using them

@Zenith00000
Copy link
Contributor

I did actually add a very similar flag with Hybrisa as I was making a TWE flag, so I thought I might as well make more. Yours do look a lot nicer though, and mine are fairly low effort. Perhaps you could replace mine with better versions or expand your PR. Either way great stuff.
(The "worn" versions are primarily up for grabs for mappers who want to make some cool inserts if you're wondering, I'm sure they could see some use.)
flags

If you are adding them with your PR then we all look forward to using them

Yeah I'm just saying that your sprites are better, the ones I did don't look as good. If you're up for improving them then I can replace the sprites I have, because I'm not satisfied with them. Either way though no worries.

@Steelpoint
Copy link
Contributor Author

I did actually add a very similar flag with Hybrisa as I was making a TWE flag, so I thought I might as well make more. Yours do look a lot nicer though, and mine are fairly low effort. Perhaps you could replace mine with better versions or expand your PR. Either way great stuff.
(The "worn" versions are primarily up for grabs for mappers who want to make some cool inserts if you're wondering, I'm sure they could see some use.)
flags

If you are adding them with your PR then we all look forward to using them

Yeah I'm just saying that your sprites are better, the ones I did don't look as good. If you're up for improving them then I can replace the sprites I have, because I'm not satisfied with them. Either way though no worries.

I think your sprites are fine insofar as being more "torn" apart which might be a good alt-set for areas that are move old/overrun, I'd still include both sets.

@Blundir
Copy link
Contributor

Blundir commented Aug 12, 2024

Yeah the ones Zenith showed are different size too, so i see no problem in having both sets

@harryob harryob added this pull request to the merge queue Aug 22, 2024
Merged via the queue into cmss13-devs:master with commit 688fae2 Aug 22, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 22, 2024
@Steelpoint Steelpoint deleted the UPPFlag branch August 23, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants