Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corporate Liaison's Wardrobe #6936

Merged
merged 14 commits into from
Aug 18, 2024
Merged

Corporate Liaison's Wardrobe #6936

merged 14 commits into from
Aug 18, 2024

Conversation

thevandie
Copy link
Contributor

@thevandie thevandie commented Aug 12, 2024

About the pull request

This PR adds a cool new vendor for the CL. Instead of that old overflowing wardrobe full of clothes, this adds a proper vendor that lets you pick and choose your outfits from a menu rather than right-clicking a stack. The vendor includes more options than the cabinet had, including workwear (for business casual), a new orange outfit I made, civilian versions of the white and black berets, and much more. All corporate roles can use it, that being any of them listed in the wy.dm file. Survivors can also use it, as they like to get fresh sets of clothes.

You're able to get one set of each clothing available, so you can't get multiples of the same clothes. However, you're able to get ONE of every item available, so you can easily supply others with clothes. This is intentional, because certain groups like fresh clothes. This could be survivors, outside WY visitors, or just someone on the ship who wants to wear a bomber jacket.

I also did some minor changes to some minor items I had included with the vendor, such as making a unique variant of the corporate boots without the knife (making sure all the roles that used to spawn with it keep the knife version), renaming the 'sunglasses' (hipster glasses) to proper prescription glasses (considering it's more accurate and we already have 'sunglasses'), changed the item sprites for some of the suits (they were old and didn't match their mobsprites), and a bit more.

This PR replaces the CL's cabinet with said vendor, I used the mapmerger tool, and I tested the mapping commit.

I also tested everything, and it all works ingame.

Explain why it's good for the game

The current cabinet is overflowing with clothes, and it doesn't leave any room for new fashion items to be added. The liaison is also one of the only roles without a vendor when they really should have a clothing vendor. CC has a vendor, CO has a vendor, CMO has a vendor, doctors have vendors, nurses have vendors, etc. It's also just a nice quality of life to be able to select your outfit from a proper GUI, rather than the right click context menu.

Testing Photographs and Procedure

Screenshots & Videos

image
Screenshot 2024-08-11 140435
image
Screenshot 2024-08-11 140453
image
image
Screenshot 2024-08-11 131427
Screenshot 2024-08-11 132445
Screenshot 2024-08-11 131712
Screenshot 2024-08-11 143951

Changelog

🆑 Vandujr
add: Added a new 'Corporate Liaison's Wardrobe' that all corporate roles can use. includes more clothes than the cabinet originally had.
add: Added a new orange outfit the CL can pick from his Wardrobe Vendor.
add: Added civilian black and white berets.
refactor: Refactored the corporate boots, making a version with and without a knife in it on spawn. All roles that should have the knife version, have it.
imageadd: Added new item sprites to the old 'complete' suits; that being the tan and formal suits, aswell as the suspenders.
imageadd: Added a new item sprite for the black beret, in line with the rest of the modern berets.
maptweak: Swapped the CL's cabinet for the wardrobe vendor.
/:cl:

Adds the vendor itself to the map
This reverts commit ad5b9ad.
This reverts commit 9091a1f.
@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Feature Feature coder badge Refactor Make the code harder to read labels Aug 12, 2024
Copy link
Contributor

@Blundir Blundir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix lower part of uniform object sprite, elaborated on discord

@Blundir Blundir marked this pull request as draft August 14, 2024 12:55
@Blundir Blundir marked this pull request as ready for review August 14, 2024 13:08
removes the webbing from the vendor, as it'll be added to req later
@Blundir Blundir added the Sprites Approved confirmed no stray pixels label Aug 14, 2024
@harryob harryob added this pull request to the merge queue Aug 18, 2024
Merged via the queue into cmss13-devs:master with commit 45f9303 Aug 18, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping did you remember to save in tgm format? Refactor Make the code harder to read Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants