-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes giant lizard code breaking when disarmed, and adds some minor features to the mob #7025
Open
VileBeggar
wants to merge
21
commits into
cmss13-devs:master
Choose a base branch
from
VileBeggar:jagras-fix-thing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+317
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm13-github
added a commit
that referenced
this pull request
Aug 24, 2024
cm13-github
added a commit
that referenced
this pull request
Aug 24, 2024
cm13-github
added a commit
that referenced
this pull request
Aug 24, 2024
cm13-github
added a commit
that referenced
this pull request
Aug 24, 2024
…, increases combat range allowing for better skirmishing
VileBeggar
changed the title
Fixes giant lizard code breaking when disarmed
Fixes giant lizard code breaking when disarmed, and adds some minor features to the mob
Aug 25, 2024
cm13-github
added a commit
that referenced
this pull request
Aug 26, 2024
cm13-github
added a commit
that referenced
this pull request
Aug 26, 2024
3 tasks
3 tasks
This was referenced Aug 27, 2024
Open
3 tasks
it's honestly pretty funny to see people get mauled by them
cm13-github
added a commit
that referenced
this pull request
Sep 2, 2024
This was referenced Sep 2, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 3, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 3, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 3, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 3, 2024
This was referenced Sep 3, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 3, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 3, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 4, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 5, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 5, 2024
cm13-github
added a commit
that referenced
this pull request
Sep 5, 2024
3 tasks
seems like a random issue, it's not directly connected to dropships and i have witnessed them getting permastunned by other sources and being completely fine with the dropship stun
cm13-github
added
the
Merge Conflict
PR can't be merged because it touched too much code
label
Sep 10, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
PR can't be merged because it touched too much code
label
Sep 14, 2024
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
stops the code from breaking when getting disarmed
they'll no longer move a tile before resting
fixes factions being constantly added by feeding them even if they were an ally beforehand (also stops the message spam)
fixes (sloppily) a weird bug where the mob would start moving even though its sprite shows it as incapacitated.
fixes (hopefully) a bug where they would never lose their target_mob when they get stuck in alert stance somehow, which would lead them to becoming inert rocks.
fixes preds taming lizards not working (their faction_group was set to NETURAL, so their actual faction was never added as an ally)
what did i learn? NEVER TRUST BYOND'S INBUILT PATHFINDING PROCS TO WORK
also adds code for breaking structures, both for the lizard AI and a player-controller one. touches up some minor things, like retreating.
they will now switch targets if they get damaged and their original one is far away
they can now vault over window frames and tables
the range for losing targets is now increased which lets skirmishes last longer and better (hopefully?).
lizards will now respawn once after a random amount of time if the current number of alive lizards is small
they'll now eat anything that has meat protein in it
damage against xenos is increased by a 1/3rd more or less
adds tongue flickering
adds wound overlays
Explain why it's good for the game
firstly, bug is bad.
secondly the other changes are something i've noticed to be needed while observing a few rounds:
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 VileBeggar, SubjectD9341
add: Giant lizards are now capable of breaking structures and their combat capabilities are slightly enhanced. Several other tweaks and minor additions have been made, such as wound overlays and tongue flickering.
add: After a random amount of time, a 2nd wave of lizards might pop up in the jungles if their numbers are too low.
fix: Giant lizards no longer become paralyzed after getting disarmed, nor will they randomly become paralyzed due to weird combat logic.
/:cl: