Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stops megaphone sound from playing #7105

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hislittlecuzingames
Copy link
Contributor

About the pull request

megaphone sound is annoying.

Explain why it's good for the game

it's annoying.
leaving line in so we can put in a new sound easily.

Testing Photographs and Procedure

Changelog

🆑
qol: remove megaphone sound playing
/:cl:

@hislittlecuzingames hislittlecuzingames marked this pull request as ready for review September 4, 2024 03:06
@github-actions github-actions bot added the Quality of Life Make the game harder to play label Sep 4, 2024
@Blundir
Copy link
Contributor

Blundir commented Sep 4, 2024

What you don't like in it exactly? I've added it. I wish we could discuss it in discord but you are not there sadly.

@github-actions github-actions bot added the Sound Blast 5 minutes of bass boosted music to our players label Sep 4, 2024
@hislittlecuzingames
Copy link
Contributor Author

What you don't like in it exactly? I've added it. I wish we could discuss it in discord but you are not there sadly.

haha yeah.

So it's kinda "screechy."
It kinda pierces the ears like nails on chalkboard, or a mic too close to its speaker.
I saw a few players complain about it.

I can see if I can apply a filter to remove some of the more "piercing" parts of the sound or something.
But yeah those are the main complaints.

I was working on a custom sound, but it doesn't sound "megaphone-ey" enough yet.
So just to work with your sound, I did some editing, and put a "megaphone_filtered.ogg" file in this PR that might let you hear what I took out of the sound.

It's kinda like that defib sound that was just the defib reversed. It is a little ear piercing, and is the reason I dislike it, just someone pr-ed it before I did.

@Blundir
Copy link
Contributor

Blundir commented Sep 4, 2024

What you don't like in it exactly? I've added it. I wish we could discuss it in discord but you are not there sadly.

haha yeah.

So it's kinda "screechy." It kinda pierces the ears like nails on chalkboard, or a mic too close to its speaker. I saw a few players complain about it.

I can see if I can apply a filter to remove some of the more "piercing" parts of the sound or something. But yeah those are the main complaints.

I was working on a custom sound, but it doesn't sound "megaphone-ey" enough yet. So just to work with your sound, I did some editing, and put a "megaphone_filtered.ogg" file in this PR that might let you hear what I took out of the sound.

It's kinda like that defib sound that was just the defib reversed. It is a little ear piercing, and is the reason I dislike it, just someone pr-ed it before I did.

Yeah if you want to make it better, go for it, also while you are at it, i might've on accident made it only hearable to the user, it's supposed to have a big radius

@hislittlecuzingames
Copy link
Contributor Author

Yeah if you want to make it better, go for it, also while you are at it, i might've on accident made it only hearable to the user, it's supposed to have a big radius

I am working on some new sounds in general.
Might do a big sound dump PR after getting feedback on sounds.

For now, I think just removing the current sound's play code is best.
Other people can hear the megaphone. Unsure if it was bugged in the past, but others hear it.

@Zonespace27 ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play Sound Blast 5 minutes of bass boosted music to our players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants