-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stops megaphone sound from playing #7105
base: master
Are you sure you want to change the base?
stops megaphone sound from playing #7105
Conversation
What you don't like in it exactly? I've added it. I wish we could discuss it in discord but you are not there sadly. |
haha yeah. So it's kinda "screechy." I can see if I can apply a filter to remove some of the more "piercing" parts of the sound or something. I was working on a custom sound, but it doesn't sound "megaphone-ey" enough yet. It's kinda like that defib sound that was just the defib reversed. It is a little ear piercing, and is the reason I dislike it, just someone pr-ed it before I did. |
Yeah if you want to make it better, go for it, also while you are at it, i might've on accident made it only hearable to the user, it's supposed to have a big radius |
I am working on some new sounds in general. For now, I think just removing the current sound's play code is best. @Zonespace27 ready for merge. |
About the pull request
megaphone sound is annoying.
Explain why it's good for the game
it's annoying.
leaving line in so we can put in a new sound easily.
Testing Photographs and Procedure
Changelog
🆑
qol: remove megaphone sound playing
/:cl: