Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prize pool rebalance for arcade machines #7150

Merged
merged 19 commits into from
Oct 26, 2024

Conversation

deathrobotpunch
Copy link
Contributor

@deathrobotpunch deathrobotpunch commented Sep 12, 2024

About the pull request

adds a fuck ton of cool and fun prizes to arcade machines that you can win!

Explain why it's good for the game

IMG_2343

I updated the list massively so there is an actual reason to play arcade machines, with the old prizes there was no incentive as there was no fun things to win.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: more items have been added to the arcade machine prize pool.
/:cl:

@cmss13-ci cmss13-ci bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Sep 12, 2024
Co-authored-by: BeagleGaming1 <[email protected]>
@Blundir
Copy link
Contributor

Blundir commented Sep 12, 2024

Remove the OWLF mask please, putting factional items in a jokingly manner isn't a good idea, also you've structured pr description that way, so before and after can be easily confused

@cuberound
Copy link
Contributor

cuberound commented Sep 12, 2024

oh god, the bikehorn, I will play the hell out of arcades to get my hands on it as scout, cool loot tho, you could add the toy lasersword too( unless that is toy/sword)

@deathrobotpunch
Copy link
Contributor Author

Remove the OWLF mask please, putting factional items in a jokingly manner isn't a good idea, also you've structrued pr description that way, so before and after can be easily confused

fine I’ll replace it with headbands!

@deathrobotpunch
Copy link
Contributor Author

deathrobotpunch commented Sep 13, 2024

OK so I found the gimmick clothes category and I want to ask, can I add the fucking rambo pants? also I edited the PR so it’s more readable

@kiVts kiVts removed the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Sep 13, 2024
@Blundir
Copy link
Contributor

Blundir commented Sep 13, 2024

OK so I found the gimmick clothes category and I want to ask, can I add the fucking rambo pants? also I edited the PR so it’s more readable

Gimmick clothing is intended for use during halloween

@deathrobotpunch
Copy link
Contributor Author

Gimmick clothing is intended for use during halloween

got it, thanks!

@cmss13-ci cmss13-ci bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Sep 13, 2024
@efzapa
Copy link
Contributor

efzapa commented Sep 17, 2024

if you know the code, maybe add charge cards with like 10-20 bucks on them, good prisoner content since they otherwise cant buy anything without an ID, but can with a charge card

EDIT: tested it locally and the following code seems to work perfectly

/obj/item/spacecash/ewallet = 100,
	worth = 25

obv replace the 100 with whatever prize weight you want

@deathrobotpunch
Copy link
Contributor Author

sure

code/game/machinery/computer/arcade.dm Outdated Show resolved Hide resolved
@Blundir Blundir marked this pull request as draft September 19, 2024 18:42
@efzapa
Copy link
Contributor

efzapa commented Sep 20, 2024

you need an intendation after the comma on the wallet item

don't think it'll work if you just use one line or no proper indents

(for example if your item is 5 indents in, your worth var needs to be 6)

@Nanu308
Copy link
Member

Nanu308 commented Oct 16, 2024

Current rewards on the PR list seems fine to me now with the changes made per request of other maintainers

@Nanu308 Nanu308 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Oct 16, 2024
@deathrobotpunch deathrobotpunch marked this pull request as ready for review October 17, 2024 04:43
@harryob harryob added this pull request to the merge queue Oct 26, 2024
Merged via the queue into cmss13-devs:master with commit 6bfe03f Oct 26, 2024
27 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants