-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fusion reactor oversight fix #7157
Draft
deathrobotpunch
wants to merge
4
commits into
cmss13-devs:master
Choose a base branch
from
deathrobotpunch:fusion-reactor-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fusion reactor oversight fix #7157
deathrobotpunch
wants to merge
4
commits into
cmss13-devs:master
from
deathrobotpunch:fusion-reactor-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
the
Missing Changelog
Maintainers always document their changes.
label
Sep 13, 2024
clearly not missing a changelog bot |
Co-authored-by: BeagleGaming1 <[email protected]>
kiVts
requested changes
Sep 19, 2024
@@ -356,7 +356,7 @@ | |||
return | |||
|
|||
set_overloading(!overloaded) | |||
to_chat(user, SPAN_WARNING("You finish [overloaded ? "overloading" : "restoring"] the safeties on [src].")) | |||
to_chat(user, SPAN_WARNING("You finish [overloaded ? "restoring" : "overloading"] the safeties on [src].")) | |||
log_game("[key_name(user)] has [overloaded ? "overloaded" : "restored the safeties of"] a generator.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here please
cmss13-ci
bot
added
Fix
Fix one bug, make ten more
and removed
Missing Changelog
Maintainers always document their changes.
labels
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
fixes #7127
This if/then/otherwise statement was activating the wrong message when it was overloaded meaning that when you were restoring safety’s then chat would say that you weren’t. switched the then statements around and now it’s working again
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
fix: fusion reactor overload messages now show correctly
/:cl: