Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusion reactor oversight fix #7157

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

deathrobotpunch
Copy link
Contributor

@deathrobotpunch deathrobotpunch commented Sep 13, 2024

About the pull request

fixes #7127

This if/then/otherwise statement was activating the wrong message when it was overloaded meaning that when you were restoring safety’s then chat would say that you weren’t. switched the then statements around and now it’s working again

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: fusion reactor overload messages now show correctly
/:cl:

@cmss13-ci cmss13-ci bot added the Missing Changelog Maintainers always document their changes. label Sep 13, 2024
@deathrobotpunch
Copy link
Contributor Author

clearly not missing a changelog bot

@@ -356,7 +356,7 @@
return

set_overloading(!overloaded)
to_chat(user, SPAN_WARNING("You finish [overloaded ? "overloading" : "restoring"] the safeties on [src]."))
to_chat(user, SPAN_WARNING("You finish [overloaded ? "restoring" : "overloading"] the safeties on [src]."))
log_game("[key_name(user)] has [overloaded ? "overloaded" : "restored the safeties of"] a generator.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here please

@kiVts kiVts marked this pull request as draft September 19, 2024 19:20
@cmss13-ci cmss13-ci bot added Fix Fix one bug, make ten more and removed Missing Changelog Maintainers always document their changes. labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong text for overloading
3 participants