Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement signal region optimization tools #8

Open
sam-may opened this issue Mar 2, 2021 · 1 comment
Open

Implement signal region optimization tools #8

sam-may opened this issue Mar 2, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@sam-may
Copy link
Collaborator

sam-may commented Mar 2, 2021

Currently, signal region optimization relies on the ttH/FCNC code (using RooFit + combine). This is fine for our purposes now, but it is a bit messy and the code is hard to read + not as flexible as I would like.

A pure-python implementation would be faster and could be made to be more configurable, readable, and user-friendly.

I'd propose to use zfit [1] as a replacement to RooFit and hepstats [2] as a replacement for combine.

I will plan to do this, but anyone else interested should feel free as well.

[1] https://github.com/zfit/zfit
[2] https://github.com/scikit-hep/hepstats

@sam-may sam-may added the enhancement New feature or request label Mar 2, 2021
@sam-may sam-may self-assigned this Mar 2, 2021
@mhl0116
Copy link
Collaborator

mhl0116 commented Mar 3, 2021

I think both are nice packages, just had a quick look at both.
One exercise that worth doing is to do side-band fit with zfit, didn't find the implementation from a quick look.

If not there, may worth adding or contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants