Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation of terms #6

Open
infossk opened this issue Dec 20, 2022 · 5 comments
Open

Confirmation of terms #6

infossk opened this issue Dec 20, 2022 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@infossk
Copy link

infossk commented Dec 20, 2022

Hi, your solution stopped working last night. I found that Abbott was doing maintenance and needed to re-confirm the terms of use before logging into the LibreLink account using the LibreLinkUp app login. Isn't it somehow possible to solve this situation in the future with automatic confirmation? Well thank you.

@cmtjk
Copy link
Owner

cmtjk commented Dec 21, 2022

Technically this might be possible but requires further analyzation. I'll have to have a look at it.
But to be honest I'm not a fan of it and I'm quite sure this is a TOS violation.

I'll label as wontfix but keep it open if someone else is interested in this feature. PRs welcome.

@cmtjk cmtjk added enhancement New feature or request wontfix This will not be worked on labels Dec 21, 2022
@infossk
Copy link
Author

infossk commented Dec 21, 2022

Technically this might be possible but requires further analyzation. I'll have to have a look at it. But to be honest I'm not a fan of it and I'm quite sure this is a TOS violation.

I'll label as wontfix but keep it open if someone else is interested in this feature. PRs welcome.

I understand. In such a case, it would perhaps be appropriate that if this state occurs, so that the user is notified that he should use the official application to approve the relevant documents, so he knows where the problem is when it stops working. Maybe it would be enough if it was in the debug information.

@cmtjk
Copy link
Owner

cmtjk commented Dec 21, 2022

Good point.
I'll check whether I can somehow make my account have to accept the TOS again and check the payload.

If someone else does not yet have accepted the TOS I'll appreciate posting the debug log here.

@cmtjk cmtjk added help wanted Extra attention is needed and removed wontfix This will not be worked on labels Dec 21, 2022
@cmtjk
Copy link
Owner

cmtjk commented Dec 21, 2022

@infossk where did you had to accept the new TOS? LibreLinkUp app or Libre 3/LibreLink app?

We can do something like this:
grafik

Unfortunately, I can't really validate the TOS thing but I think it's covered by the new message which will pop up if no data was received.
I'll make a pre-release available to test it, since I want to make sure the alert does not pop up randomly when there's a short-term issue fetching the data.

@cmtjk
Copy link
Owner

cmtjk commented Dec 21, 2022

@cmtjk cmtjk added the question Further information is requested label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants