You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This gives the impression to readers on a glance that the functions are actually modifying the data they are hashing, which I'm fairly sure is not the case!
It also has the inconvenience that to hash an object that is already const qualified you have to add an explicit cast, e.g.:
Input pointer parameters in the function signatures are not const, e.g.:
static meow_u128 MeowHash(void *Seed128Init, meow_umm Len, void *SourceInit)
This gives the impression to readers on a glance that the functions are actually modifying the data they are hashing, which I'm fairly sure is not the case!
It also has the inconvenience that to hash an object that is already const qualified you have to add an explicit cast, e.g.:
Could we please have the function signatures updated to take all input parameters by const pointer?
Thanks!
The text was updated successfully, but these errors were encountered: