Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on Win11 + VS2022 #30

Open
elsaco opened this issue Nov 29, 2021 · 3 comments
Open

Build fails on Win11 + VS2022 #30

elsaco opened this issue Nov 29, 2021 · 3 comments

Comments

@elsaco
Copy link

elsaco commented Nov 29, 2021

Running build.bat there are 2 warning and 2 errors. Sample error:

termbench.cpp:286:43: error: constant expression evaluates to 17179869184 which cannot be narrowed to type 'size_t' (aka 'unsigned int') [-Wc++11-narrowing]
    {"ManyLine", ManyLine, {1*Meg, 1*Gig, 16*Gig}},
                                          ^~~~~~
termbench.cpp:286:43: note: insert an explicit cast to silence this issue
    {"ManyLine", ManyLine, {1*Meg, 1*Gig, 16*Gig}},
                                          ^~~~~~
                                          static_cast<size_t>( )

How do you build termbench on Win11 + VS2022? Thx.

@cmuratori
Copy link
Owner

This looks like you are using the 32-bit compiler. Use the 64-bit compiler instead.

We can probably just force that value to be a 64-bit value, though, and this would work even on the 32-bit compiler, so, that might be a good idea...

- Casey

@elsaco
Copy link
Author

elsaco commented Nov 30, 2021

Using the 64-bit compiler worked. No errors. Thx!

@elsaco elsaco closed this as completed Nov 30, 2021
@cmuratori
Copy link
Owner

I'm going to leave this issue open until I have a chance to check the codebase, though. I believe there is no real reason why the code can't work in 32-bit mode with some slight modifications, so I may just go ahead and do that to avoid requiring a 64-bit compiler for no real reason.

- Casey

@cmuratori cmuratori reopened this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants