Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use this module with firelens #69

Closed
typhoonese opened this issue Jan 9, 2023 · 4 comments
Closed

Unable to use this module with firelens #69

typhoonese opened this issue Jan 9, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@typhoonese
Copy link

When attempting to use firelens with this module, I get the following error: ClientException: When awsfirelens log driver is specified in log configuration, a firelens configuration object must be configured in one of the containers. How can we go around this?

It seems that firelens should be defined in the same container definition as the other container created with this module. However, I don't see any input options that enable this. Could you please help? It'd be much appreciated!

@adeeshaek
Copy link

Just chiming in to add that I also ran into this issue. To generalize it a bit further, it appears that this module does not support the use of any kind of sidecar containers.

@JaredDarling
Copy link
Contributor

JaredDarling commented Sep 13, 2023

I have an implementation in a fork I'm working on now that will allow for sidecars. I have tested it to create datadag and fluent-bit agents and it seems to be working, but I have one final detail of connectivity to datadog to confirm before I call it tested and ready.

@jnonino
Copy link
Member

jnonino commented Sep 19, 2023

Hi @typhoonese, @adeeshaek thank you for reaching out about this. I will work on this as soon as I can. In the meantime, if you have a solution like @JaredDarling, please do not hesitate to submit a PR, I will review it and merge it ASAP so you can use straight away.

@JaredDarling
Copy link
Contributor

Fixed by #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

4 participants