Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: iframe content not accounted for when calculating ecoindex #34

Open
1 task done
PierreRustOrange opened this issue Feb 27, 2023 · 5 comments
Open
1 task done
Assignees
Labels
bug Something isn't working keep open

Comments

@PierreRustOrange
Copy link
Member

PierreRustOrange commented Feb 27, 2023

What happened?

ecoindex_cli does not take the content of iframes into account when calculating the ecoindex of a page.

I'm using the following files as a testcase.zip, served locally on port 8080.
I analyze the page using the following command and get this result :

ecoindex-cli analyze --url http://127.0.0.1:8080/testEcoIndexIFrame.html --export-format json --outputfile ./result.json

result:

[
    {
        "width": 1920,
        "height": 1080,
        "url": "http://127.0.0.1:8080/testEcoIndexIFrame.html",
        "size": 2.511,
        "nodes": 6,
        "requests": 3,
        "grade": "A",
        "score": 97.0,
        "ges": 1.06,
        "water": 1.59,
        "ecoindex_version": "5.4.1",
        "date": "2023-02-27 17:50:40.593434",
        "page_type": null
    }
]

The number of DOM nodes detected by ecoindex-cli is 6, which maps the content of the main html file, but does not include the content of the html inside the iframe.
The number of requests and the size seems to be correct though : when I increase the subPage.hml page's size, the size reported by ecoindex-cli increases as well.

On some real life pages, this can make a huge different in the final rank obtained when analyzing a page (from G to E rank).

Version

Above 3.6

What OS do you use?

Linux

urls

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@PierreRustOrange PierreRustOrange added the bug Something isn't working label Feb 27, 2023
@vvatelot vvatelot self-assigned this Feb 27, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
@vvatelot vvatelot reopened this Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2023
@vvatelot vvatelot reopened this Oct 12, 2023
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

1 similar comment
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
@vvatelot vvatelot reopened this Dec 19, 2023
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@vvatelot vvatelot transferred this issue from cnumr/ecoindex_cli Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keep open
Projects
None yet
Development

No branches or pull requests

2 participants