-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: iframe content not accounted for when calculating ecoindex #34
Comments
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
1 similar comment
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
What happened?
ecoindex_cli does not take the content of iframes into account when calculating the ecoindex of a page.
I'm using the following files as a testcase.zip, served locally on port 8080.
I analyze the page using the following command and get this result :
result:
The number of DOM nodes detected by ecoindex-cli is 6, which maps the content of the main html file, but does not include the content of the html inside the iframe.
The number of requests and the size seems to be correct though : when I increase the subPage.hml page's size, the size reported by ecoindex-cli increases as well.
On some real life pages, this can make a huge different in the final rank obtained when analyzing a page (from G to E rank).
Version
Above 3.6
What OS do you use?
Linux
urls
No response
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: