Use tox #2910
Merged
Use tox #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage appearing at https://codecov.io/gh/coala/coala-bears/tree/c50ebe9/bears 99.9% The remaining coverage is Constants, which is only used by Having coverage at 100% isnt critical any more because of the use of per-file 100% coverage requirements. We should remove Constants. Anyway, this will be fixed by running the docs inside tox also. |
jayvdb
commented
May 25, 2019
jayvdb
commented
May 25, 2019
|
The travis failures are intentional, and will be added to "allowed failures", except for Elm and Haskell, the two languages which are supported by Travis but not yet working. Another change I'll likely try getting into this PR is adding Linux to AppVeyor, as it supports Bionic, which the apt_get factor should handle ok, and there are many more bears with OS distributed packages in bionic. |
This was referenced May 26, 2019
This was referenced Jun 4, 2019
jayvdb
force-pushed
the
tox
branch
4 times, most recently
from
b44ab18 to
8813076
Compare
jayvdb
commented
Jun 29, 2019
jayvdb
commented
Jun 29, 2019
jayvdb
commented
Jun 30, 2019
jayvdb
force-pushed
the
tox
branch
2 times, most recently
from
2e149da to
852a3b7
Compare
jayvdb
commented
Jun 30, 2019
jayvdb
commented
Jun 30, 2019
jayvdb
commented
Jul 18, 2019
jayvdb
commented
Jul 18, 2019
jayvdb
commented
Jul 18, 2019
jayvdb
commented
Jul 18, 2019
jayvdb
commented
Jul 19, 2019
jayvdb
force-pushed
the
tox
branch
4 times, most recently
from
bb63381 to
63991bb
Compare
jayvdb
commented
Jul 20, 2019
jayvdb
force-pushed
the
tox
branch
3 times, most recently
from
6b9b27c to
2928f92
Compare
This rewrites `.ci/generate_bear_requirements.py` to inject more metadata into new file bear-metadata.yaml.
This Circle CI v1 file is no longer useful since Circle CI now requires a v2 file, which will be significantly different. Related to coala#2298
This reverts commit c77ee65. coala bears does not control the installed versions on users machines. The package.json in this repository is generated to aide installing, and is not used to build a product and is therefore not locked! CI fails when the lock is not maintained, and we have no reason to maintain a lock file. Related to coala#2508
Setting check_end_labels was created to remove the need to add copious comments in the Jinja templates. These help with Jinja2 templates, however there are other unavoidable errors with bears-travis.yml.jj2
jayvdb
commented
Jul 21, 2019
jayvdb
force-pushed
the
tox
branch
2 times, most recently
from
2346c2b to
a10afdf
Compare
This replaces Travis CI 'single image' with one VM for each set of bears with similar dependencies, using tox to select the sets. And it replaces AppVeyor CI to use FudgeCI to be a managable 'single image' VM that includes most of the dependencies needed by bears, and uses tox to select the sets of bears. The tox setup allows being used with or without --sitepackages, and the AppVeyor CI does use --sitepackages and other tricks to allow .ps1 finer control over the process of installing python dependencies. This uses tox-backticks to allow multiple selectors to be mapped to multiple tests that pytest will run. It uses pytest-cov-threshold to allow custom thresholds for each source file, allowing each job to deselect the source files that need coverage depending on the selected tests for the job.
This was referenced Jul 21, 2019
jayvdb
added a commit
to jayvdb/coala-bears
that referenced
this pull request
Jul 24, 2019
Running of .ci/deps.coala-bears.sh was removed from tox.ini during the cleanup of coala#2910 but was necessary and the problem masked by the CI cache. Fixes coala#2937
jayvdb
added a commit
to jayvdb/coala-bears
that referenced
this pull request
Aug 3, 2019
Running of .ci/deps.coala-bears.sh was removed from tox.ini during the cleanup of coala#2910 but was necessary and the problem masked by the CI cache. Fixes coala#2937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Green builds, and lots of closes. Continues #1386 . This is a new PR because that one is so old and has some interesting implementation choices where are no longer relevant due to new approaches.
WIP as the commits need to be split up, linked to issues, etc.
A few parts of this are hopefully going to be replaced with PRs underway by other folk, otherwise I'll take over the assigned issues.
This also implements https://gitlab.com/coala/mobans/merge_requests/130 for Windows CI on both AppVeyor and Travis CI.