Skip to content
This repository has been archived by the owner on Feb 1, 2019. It is now read-only.

CI: Add coala in CI #22

Closed
gaocegege opened this issue Dec 26, 2017 · 7 comments
Closed

CI: Add coala in CI #22

gaocegege opened this issue Dec 26, 2017 · 7 comments

Comments

@gaocegege
Copy link
Member

Now our builds on Travis CI does not check coala issues.

@gaocegege gaocegege changed the title [enhancement] Add coala in CI CI: Add coala in CI Dec 26, 2017
@kiryteo
Copy link

kiryteo commented Dec 27, 2017

Can I work on this.?

@kiryteo
Copy link

kiryteo commented Dec 28, 2017

How can I proceed and what is the expected outcome for this.?

@gaocegege
Copy link
Member Author

@kiryteo

There are some errors when we use coala: #23 , but you do not need to deal with them. This issue is to import coala into Travis CI build, so if you could add coala --ci into the config yaml file, and it works, then it works for me.

@kiryteo
Copy link

kiryteo commented Dec 30, 2017

I tried adding '-run coala --ci' in the travis.yml script section but the build fails..

@gaocegege
Copy link
Member Author

gaocegege commented Dec 30, 2017

@kiryteo

Yes but it does not matter. It is caused by #23 and you could file the PR and I will review and merge it if it could report errors in the CI build.

@kiryteo
Copy link

kiryteo commented Dec 30, 2017

I'll make the PR with modified travis.yml file..

@Makman2
Copy link
Member

Makman2 commented Jan 1, 2018

Btw: I've enabled coala analysis via gitmate, I hope it works for future PRs too (but I haven't seen it on the PRs yet, so let's do this issue anyway)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants