Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: incorrect (0) usage information for unmounted btrfs subvolume #20852

Open
KKoukiou opened this issue Aug 8, 2024 · 3 comments
Open

Comments

@KKoukiou
Copy link
Contributor

KKoukiou commented Aug 8, 2024

Page: Storage

Before mounting:
127 0 0 2_9091_cockpit_@localhost_anaconda-webui_index html

After mounting:
127 0 0 2_9091_cockpit_@localhost_anaconda-webui_index html (1)

Since we can't get this info before mounting maybe we should not show that at all?

@garrett
Copy link
Member

garrett commented Aug 8, 2024

It'd be great to have the usage without mounting, but if we can't do that, I agree that we shouldn't show it. We already have size.

Aside: Oddly, size and usage have different amounts. Size has 12.8 GB and usage shows 13 GB. Where does the 0.2 GB come from? Are there rounding-related errors?

@jkonecny12
Copy link

In general it's quite problematic for Anaconda that Cockpit Storage requires to mount volume before it can start working with subvolumes.
The issue is that volume is not really usable when mounted (at least not recommended) so forcing user to set mount point and everything is confusing. This is especially true in Anaconda where we are taking these mount points for installation and (correctly) skipping the volume mount.

@garrett
Copy link
Member

garrett commented Aug 8, 2024

In general it's quite problematic for Anaconda that Cockpit Storage requires to mount volume before it can start working with subvolumes. The issue is that volume is not really usable when mounted (at least not recommended) so forcing user to set mount point and everything is confusing. This is especially true in Anaconda where we are taking these mount points for installation and (correctly) skipping the volume mount.

Filed more generally about having to mount to perform operations @ #20855

(I consider this particular issue as different, as it would be solved by removing the usage when we can't show it. And the other is the more general case for all explicit actions that require mounting.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants