Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branding: distro logo is placed behind dark overlay in dark mode #21378

Open
logonoff opened this issue Dec 3, 2024 · 3 comments · May be fixed by #21379
Open

branding: distro logo is placed behind dark overlay in dark mode #21378

logonoff opened this issue Dec 3, 2024 · 3 comments · May be fixed by #21379
Labels

Comments

@logonoff
Copy link
Contributor

logonoff commented Dec 3, 2024

Explain what happens

In the login page, the distro logo appears behind the darkened layer

image
image
image
image

Version of Cockpit

cockpit 323.1

Where is the problem in Cockpit?

Login page

Server operating system

Red Hat Enterprise Linux

Server operating system version

9.5

What browsers are you using?

Firefox

System log

No response

@martinpitt
Copy link
Member

Hello @logonoff ! It seems to me that this is actually intended, as per this comment: https://github.com/cockpit-project/cockpit/blob/ab76818721182151b/pkg/static/login.scss#L1027

It also seems to make sense to me, as the whole point of dark mode is to avoid bright colors in dark environments -- so tinting the logo would make sense, too?

@garrett can you please comment? The fix in #21379 is straightforward, but I'm not at all sure that we actually want it.

Thanks!

@logonoff
Copy link
Contributor Author

logonoff commented Dec 4, 2024

Ah, if it's a feature feel free to disregard the PR. The darkened branding just looked a little off to my eyes and it probably violates some brand guidelines

@garrett
Copy link
Member

garrett commented Dec 12, 2024

Yeah, it was intentional. We could either drop it completely, or we could split the difference and perhaps 75% or 80% instead of 66%? It does feel a little too dark.

https://github.com/cockpit-project/cockpit/blob/ab76818721182151b/pkg/static/login.scss#L1032C1-L1032C19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants