test: Ignore bottom panel in TestHistoryMetrics.testEvents pixel test #21423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
the
no-test
In the medium layout, the bottom panel sometimes has an extra white background line (padding). This is random and unpredictable (probably rounding noise?). That panel only contains a single standard button, so is not very interesting. We can't use `ignore=` for that, as the difference is the snapshot height, not the pixel contents. So instead, temporarily hide the whole bottom panel for the snapshot. Fixes cockpit-project#21422
martinpitt
force-pushed
the
history-flake
branch
from
3a6de04 to
729f85c
Compare
|
@mvollmer This is an utter hack. Please tell me I missed something, and there's a better way 🙈 |
mvollmer
approved these changes
Dec 12, 2024
| @@ -247,9 +247,14 @@ class TestHistoryMetrics(testlib.MachineCase): | |||
| b.wait_in_text("#metrics-hour-1597662000000.metrics-hour-compressed .spikes_count", "3 spikes") | |||
| b.wait_in_text("#metrics-hour-1597662000000.metrics-hour-compressed .spikes_info", "1 Memory, 1 Disk I/O, 1 Network I/O") | |||
|
|
|||
| # HACK: the bottom panel has some unpredictable extra white line at the bottom, but is also uninteresting | |||
| b.eval_js("document.querySelector('.bottom-panel').style.display = 'none'") | |||
There was a problem hiding this comment.
Can we use mock for this?
mock={ ".bottom-panel": "" }
There was a problem hiding this comment.
That's a great idea, but unfortunately not. It produces this:
which valdalizes the button, but keeps the problematic space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the medium layout, the bottom panel sometimes has an extra white
background line (padding). This is random and unpredictable (probably
rounding noise?). That panel only contains a single standard button, so
is not very interesting.
We can't use
ignore=for that, as the difference is the snapshotheight, not the pixel contents. So instead, temporarily hide the whole
bottom panel for the snapshot.
Fixes #21422