Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Revert menu toggles to be transparent again #21434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: Revert menu toggles to be transparent again #21434

wants to merge 1 commit into from
+18 −9

Conversation

mvollmer
Copy link
Member

This broke Anaconda. Instead, only change them in "logs" and "metrics".

@mvollmer
lib: Revert menu toggles to be transparent again
025d539 
This broke Anaconda.  Instead, only change them in "logs" and
"metrics".
@mvollmer mvollmer requested a review from KKoukiou December 13, 2024 14:39
@mvollmer mvollmer added the release-blocker Targetted for next release label Dec 13, 2024
@mvollmer
Copy link
Member Author

There shouldn't be any pixel changes.

martinpitt
martinpitt approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bots (pixel tests) have the last word, but pre-approving. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

@KKoukiou KKoukiou Awaiting requested review from KKoukiou

Assignees
No one assigned
Labels
release-blocker Targetted for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvollmer @martinpitt