From 73d7ca2584083094c2adcd0e75edc21492d65bce Mon Sep 17 00:00:00 2001 From: Ricky Stewart Date: Tue, 27 Aug 2024 12:26:17 -0500 Subject: [PATCH] dev: also build `ts_project` for `eslint-plugin-crdb` in `gen js` Without this, generation can fail with an error like: ``` Rel: can't make relative to /private/var/tmp/_bazel_davidh/d61affdd093572eb0c41c4220c20a747/execroot/com_github_cockroachdb_cockroach/bazel-out/darwin_arm64-fastbuild/bin/pkg/ui/workspaces/eslint-plugin-crdb/dist ``` It's unclear right now why this is happening. My suspicion is there is some sort of bug or deficiency in `rules_js` and/or `rules_ts` specifically on more recent Bazel versions and is probably related to Bazel 7 being more aggressive about rejecting using directories as output files. Epic: none Release note: None Closes: #129369 --- pkg/cmd/dev/generate.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/dev/generate.go b/pkg/cmd/dev/generate.go index 01f0417492a0..8fd17c17c2e7 100644 --- a/pkg/cmd/dev/generate.go +++ b/pkg/cmd/dev/generate.go @@ -309,7 +309,7 @@ func (d *dev) generateJs(cmd *cobra.Command) error { args := []string{ "build", - "//pkg/ui/workspaces/eslint-plugin-crdb:eslint-plugin-crdb-lib", + "//pkg/ui/workspaces/eslint-plugin-crdb:ts_project", "//pkg/ui/workspaces/db-console/src/js:crdb-protobuf-client", "//pkg/ui/workspaces/cluster-ui:ts_project", }