Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crosscluster: fail creating the PCR job if destination has a cluster version less than the source #131541

Open
msbutler opened this issue Sep 27, 2024 · 2 comments
Open

crosscluster: fail creating the PCR job if destination has a cluster version less than the source #131541

msbutler opened this issue Sep 27, 2024 · 2 comments
Assignees
@azhu-crl
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Sep 27, 2024 •
edited by cockroach-jira-scripts
Loading

We can do so by adding a check here where we create the producer job
https://github.com/msbutler/cockroach/blob/butler-sql-origin-ts/pkg/ccl/crosscluster/producer/stream_lifetime.go#L98-L99

And plumbing the destination cluster version in the ReplicationProducerRequest

Jira issue: CRDB-42590
@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery labels Sep 27, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Sep 27, 2024

cc @cockroachdb/disaster-recovery

@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Sep 30, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Oct 28, 2024

Hi @msbutler, please add branch-* labels to identify which branch(es) this GA-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@msbutler msbutler added backport-24.3.x Flags PRs that need to be backported to 24.3 and removed GA-blocker backport-24.3.x Flags PRs that need to be backported to 24.3 labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azhu-crl azhu-crl

Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msbutler @azhu-crl