Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: schemachange/mixed-versions failed [use REFCURSOR prior to 23.2] #132815

Closed
cockroach-teamcity opened this issue Oct 17, 2024 · 2 comments
Assignees
Labels
branch-release-23.2.13-rc C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 17, 2024

roachtest.schemachange/mixed-versions failed with artifacts on release-23.2.13-rc @ f00c152761838e05049d293198840b12605b545b:

(mixedversion.go:710).Run: mixed-version test failure while running step 13 (run "run schemachange workload and validation in mixed version"): full command output in run_062439.553147651_n4_COCKROACHRANDOMSEED7.log: COMMAND_PROBLEM: exit status 1
test artifacts and logs in: /artifacts/schemachange/mixed-versions/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-43286

@cockroach-teamcity cockroach-teamcity added branch-release-23.2.13-rc C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Oct 17, 2024
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Oct 17, 2024
@spilchen
Copy link
Contributor

The failure is:

  |   "previousStatements": [
  |    "ALTER TABLE public.table2824 ALTER COLUMN \"col2824_2825\" SET DEFAULT 'G':::REFCURSOR"
  |   ]
  |  }
  | }
  |
  | stderr:I241017 06:24:40.004814 1 workload/cli/run.go:431  [-] 1  creating load generator...
  | I241017 06:24:40.136488 1 workload/cli/run.go:470  [-] 2  creating load generator... done (took 131.674146ms)
  | Error: ***UNEXPECTED ERROR; Received an unexpected execution error.: ERROR: refcursor not supported until version 23.2 (SQLSTATE 0A000)

We probably just need to add a version gate when attempting to set the default of a column to REFCURSOR

@spilchen spilchen changed the title roachtest: schemachange/mixed-versions failed roachtest: schemachange/mixed-versions failed [use REFCURSOR prior to 23.2] Oct 22, 2024
@spilchen
Copy link
Contributor

Similar to #128941, but this one is for ALTER COLUMN

@spilchen spilchen self-assigned this Oct 22, 2024
@spilchen spilchen added P-2 Issues/test failures with a fix SLA of 3 months and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Oct 22, 2024
spilchen added a commit to spilchen/cockroach that referenced this issue Oct 24, 2024
…set default

Similar to cockroachdb#128941, we can end up using PGLSN or REFCUSOR in a
mixed-version workload. This adds version gates so we check for
correct errors if we attempt to use them while setting column
defaults.

Fixes: cockroachdb#132815
Release note: None
Release justification: bug fix for a test
@rafiss rafiss closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-23.2.13-rc C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

3 participants