Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COCKROACH_BINARY does not work as expected #81

Open
irfansharif opened this issue Oct 31, 2019 · 1 comment
Open

COCKROACH_BINARY does not work as expected #81

irfansharif opened this issue Oct 31, 2019 · 1 comment
Assignees

Comments

@irfansharif
Copy link
Contributor

COCKROACH_BINARY does not work with "~" paths, and is relative to the testing folder (as opposed to the folder with the Makefile), which should be called out. While on the subject of documentation, we should make make dockertest a first class citizen, it's much better than asking someone looking to jump in to figure out all the ORM dependencies they need to install.

We should include a COCKROACH_BINARY usage example for both make test and make dockertest (which would rely on a linux build of CRDB).

@irfansharif
Copy link
Contributor Author

I'm told the path issue is an underlying problem in https://github.com/cockroachdb/cockroach-go/blob/master/testserver/testserver.go, but this is where I ran into it, so 🏃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants