Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Support for Tuples? #22

Open
lambdaknight opened this issue Jun 22, 2011 · 8 comments
Open

Support for Tuples? #22

lambdaknight opened this issue Jun 22, 2011 · 8 comments

Comments

@lambdaknight
Copy link

Right now, Tuples are not supported by Jerkson, though it seems like they could easily be added. Your CaseClassSerializer/Deserializer classes are remarkably close to what is needed.

@codahale
Copy link
Owner

Patches accepted.

@codahale
Copy link
Owner

FWIW, what makes this hard is that you'd need a deserializer for Tuple1 through Tuple22, or one big deserializer with a huge switch on arity. It's not a pressing need for me right now, but if someone else wants to take this on I'd merge it and maintain it.

@acruise
Copy link

acruise commented Sep 15, 2011

I think it's pretty awesome that this is issue #22.

@acruise
Copy link

acruise commented Sep 15, 2011

Also, what would they look like? { "_1": 1, "_2": "two", "_3": 3.0 } ?

@codahale
Copy link
Owner

Oh, hell no.

[1, "two", 3.0]

Coda Hale
http://codahale.com

On Thursday, September 15, 2011 at 1:49 PM, Alex Cruise wrote:

Also, what would they look like? { "_1": 1, "_2": "two", "_3": 3.0 } ?

Reply to this email directly or view it on GitHub:
#22 (comment)

codahale added a commit that referenced this issue Sep 16, 2011
This reverts commit d592703.

Reopens #22.

I hate you, Scala 2.8.1. I hate you, people who use it.
@belindagu
Copy link

This should be open now, given the revert, correct?

I'm very interested in getting this to work for Jerkson. Can you clarify how d592703 with 2.9.1 enables this scenario? I tried applying the commit, but it didn't seem to fix the problem for tuples.

@codahale codahale reopened this Sep 30, 2011
@codahale
Copy link
Owner

That commit was indeed unrelated.

@josephw
Copy link

josephw commented Jul 26, 2012

I've attempted an implementation of this as josephw/jerkson@c189f6c and opened a pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants