Skip to content

Commit

Permalink
Make some properties nullable
Browse files Browse the repository at this point in the history
  • Loading branch information
boma96 committed Nov 25, 2024
1 parent 464f061 commit bf31b37
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/ConductorSharp.Client/ConductorSharp.Client.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Authors>Codaxy</Authors>
<Company>Codaxy</Company>
<PackageId>ConductorSharp.Client</PackageId>
<Version>2.4.0</Version>
<Version>2.4.1</Version>
<Description>Client library for Netflix Conductor, with some additional quality of life features.</Description>
<RepositoryUrl>https://github.com/codaxy/conductor-sharp</RepositoryUrl>
<PackageTags>netflix;conductor</PackageTags>
Expand Down
4 changes: 2 additions & 2 deletions src/ConductorSharp.Client/Model/Common/TaskDefinition.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ public class TaskDefinition
public string OwnerApp { get; set; } = "[email protected]";

[JsonProperty("createTime")]
public long CreateTime { get; set; }
public long? CreateTime { get; set; }

[JsonProperty("updateTime")]
public long UpdateTime { get; set; }
public long? UpdateTime { get; set; }

[JsonProperty("createdBy")]
public string CreatedBy { get; set; }
Expand Down
4 changes: 2 additions & 2 deletions src/ConductorSharp.Client/Model/Common/WorkflowDefinition.cs
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,10 @@ public JObject InputParameters
public string OwnerApp { get; set; }

[JsonProperty("createTime")]
public long CreateTime { get; set; }
public long? CreateTime { get; set; }

[JsonProperty("updateTime")]
public long UpdateTime { get; set; }
public long? UpdateTime { get; set; }

[JsonProperty("createdBy")]
public string CreatedBy { get; set; }
Expand Down
2 changes: 2 additions & 0 deletions src/ConductorSharp.Engine/Builders/TaskDefinitionBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ public TaskDefinition Build(Type taskType, Action<TaskDefinitionOptions> updateO
UpdatedBy = options.UpdatedBy,
InputTemplate = options.InputTemplate,
ExecutionNameSpace = options.ExecutionNameSpace,
CreateTime = 0,
UpdateTime = 0
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ public WorkflowDefinition Build()
OutputParameters = BuildContext.Outputs,
OwnerApp = BuildContext.WorkflowOptions.OwnerApp,
OwnerEmail = BuildContext.WorkflowOptions.OwnerEmail,
Version = BuildContext.WorkflowOptions.Version
Version = BuildContext.WorkflowOptions.Version,
CreateTime = 0,
UpdateTime = 0
};
}

Expand Down
2 changes: 1 addition & 1 deletion src/ConductorSharp.Engine/ConductorSharp.Engine.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Authors>Codaxy</Authors>
<Company>Codaxy</Company>
<PackageId>ConductorSharp.Engine</PackageId>
<Version>2.4.0</Version>
<Version>2.4.1</Version>
<Description>Client library for Netflix Conductor, with some additional quality of life features.</Description>
<RepositoryUrl>https://github.com/codaxy/conductor-sharp</RepositoryUrl>
<PackageTags>netflix;conductor</PackageTags>
Expand Down
2 changes: 1 addition & 1 deletion src/ConductorSharp.Patterns/ConductorSharp.Patterns.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<GeneratePackageOnBuild>False</GeneratePackageOnBuild>
<Authors>Codaxy</Authors>
<Company>Codaxy</Company>
<Version>2.4.0</Version>
<Version>2.4.1</Version>
</PropertyGroup>

<ItemGroup>
Expand Down

0 comments on commit bf31b37

Please sign in to comment.