Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo and a possible misuse of complex type destructuring #198

Open
tymarats opened this issue Feb 4, 2025 · 0 comments
Open

A typo and a possible misuse of complex type destructuring #198

tymarats opened this issue Feb 4, 2025 · 0 comments

Comments

@tymarats
Copy link
Contributor

tymarats commented Feb 4, 2025 •
edited
Loading

In this line:

  1. "occurred" is misspelled (one "r" is missing)
  2. Consider using _logger.LogError(ex, $"Error occurred...", ...) instead of _logger.LogError($"Exception {@Exception} occurred...", ex, ...)

As a sidenote, every exception is logged twice--once with the performance counters and once without, e.g.:

Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tymarats