Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #163

Open
code423n4 opened this issue Nov 14, 2022 · 4 comments
Open

QA Report #163

code423n4 opened this issue Nov 14, 2022 · 4 comments
Labels
bug Something isn't working grade-a Q-13 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Nov 14, 2022
code423n4 added a commit that referenced this issue Nov 14, 2022
@code423n4
joestakey issue #163
d07113c
code423n4 added a commit that referenced this issue Nov 14, 2022
@code423n4
joestakey data for issue #163
9c20168
@c4-judge
Copy link
Contributor

berndartmueller marked the issue as grade-b

@joestakey
Copy link

Hi @berndartmueller , this report has 8 Low issues and was graded as B, while reports with fewer Lows (54 has 5, 39 has 3) were graded as A. Shouldn't it be graded as A too?

@berndartmueller
Copy link
Member

Hi @berndartmueller , this report has 8 Low issues and was graded as B, while reports with fewer Lows (54 has 5, 39 has 3) were graded as A. Shouldn't it be graded as A too?

Hey @joestakey! After reviewing your QA report again, I'm on your side that it should be graded as A. For full transparency, I favored comprehensive QA and gas reports with a table of contents section for A graded reports. But as you have reported plenty of low-severity issues, you should get rewarded for that.

@c4-judge c4-judge added grade-a and removed grade-b labels Dec 1, 2022
@c4-judge
Copy link
Contributor

c4-judge commented Dec 1, 2022

berndartmueller marked the issue as grade-a

@C4-Staff C4-Staff added the Q-13 label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-a Q-13 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@berndartmueller @code423n4 @joestakey @c4-judge @C4-Staff