QA Report

[howlbot-integration]

See the markdown file with the details of this report here.

[aviggiano]

1. Acknowledged. It is unlikely that Aave would turn their referral program back on. If they do, we can redeploy the contracts
2. Disputed. This is by design
3. Disputed. maxAPR does not consider fees
4. Disputed. See When the borrowAToken cap is reached, users may not always be able to repay their debt in some cases due to precision errors #19
5. Acknowledged. The choice of rounding here is arbitrary, since the protocol also wants to help out the borrower by improving their CR after a liquidation.
6. Acknowledged. This was already flagged by Spearbit and addressed there
7. Confirmed. Resolved in c4-016 Documentation fixes SizeCredit/size-solidity#135
8. Disputed. This is by design
9. Disputed. Invalid, see Chainlink's latestRoundData might return stale or incorrect results in PriceFeed.sol #212
10. Disputed. Reverting can cause other problems, such as a failure to liquidate
11. Acknowledged.
12. Confirmed. Resolved in c4-016 Documentation fixes SizeCredit/size-solidity#135
13. Disputed. See Protocol pausing during market volatility can prevent lenders from self-liquidating debt, potentially leading to significant financial losses. #199

[c4-judge]

hansfriese marked the issue as grade-b

[c4-judge]

hansfriese marked the issue as grade-a

[0xhacksmithh]

@hansfriese Please check Low-08
I think it should be a Problem when User have multiple creditPositions

For example:
To sell CreditPosit-1 where creditPosition.forSale = True User have to user.allCreditPositionsForSaleDisabled = False to get pass through that check,

when user made allCreditPositionsForSaleDisabled = False it may open up different problem,

• as i mention when CreditPosition created it by defult set to creditPosition.forSale = True
• in this senario may be User have multiple CreditPositions (some of them may be on good deals)
• So other Party can buy those Position without User's selling intention
• User may be not aware of this default selling is set to TRUE, only aware of allCreditPositionsForSaleDisabled
• If User know about this he has to manually set all of his Positions to forSale = False
• and reverse them on other case

thats why i submit this under QA

[0xhacksmithh]

Sponcer Description on Low-03 is not clear

[hansfriese]

For Low-8, I agree with the sponsor's assessment, as it does not demonstrate any specific impacts.
The ranking of this report will be determined after a vote by the validators and myself.

[thebrittfactor]

For awarding purposes, C4 staff have marked as 2nd place.