Upgraded Q -> 2 from #543 [1727783721379]

[c4-judge]

Judge has assessed an item in Issue #543 as 2 risk. The relevant finding follows:

[L01] When users use _transferFrom() to transfer funds via ApprovalType.PERMIT approval type, the transaction may be reverted if malicious user frontrun the related permit.

function _transferFrom(
    address token,
    address from,
    address to,
    uint256 amount,
    PermitParams memory params
) internal {
    if (params.approvalType == ApprovalType.PERMIT2) {
        ...
    } else if (params.approvalType == ApprovalType.PERMIT) {
        // Consume a standard ERC20 permit message
        // @audit this will be blocked.
        IERC20Permit(token).safePermit(
            from,
            to,
            params.approvalAmount,
            params.deadline,
            params.v,
            params.r,
            params.s
        );
        IERC20(token).safeTransferFrom(from, to, amount);
    } else {
        ...
    }
}

[c4-judge]

koolexcrypto marked the issue as duplicate of #205

[c4-judge]

koolexcrypto marked the issue as satisfactory