Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space to Play/Pause double pressing when adding space as a shortcut for play/pause #1889

Closed
Alenthas opened this issue Dec 16, 2023 · 3 comments
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Alenthas
Copy link

When alt tabbing back into firefox with the specific youtube video open, pressing space doesn't pause or unpause the video. You have to click on the browser with your mouse to get space key to work. To fix this, I set it up within the addon to have the same functionality, so that I can pause or unpause without having to click on the browser. This works so long as I alt tab into firefox, but if at any point I click on the browser both shortcuts work in tandem, resulting in space being double pressed, so you can't pause/unpause.

@Alenthas Alenthas added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Dec 16, 2023
@ImprovedTube ImprovedTube added Completion / Revision Rethink, complete, improve, tweak our feature or structure. and removed Bug Bug or required update after YouTube changes labels Dec 17, 2023
@ImprovedTube
Copy link
Member

hi! @Alenthas
you can disallow youtube to listen to space (to unoccupy it) with our:
https://addons.mozilla.org/en-US/firefox/addon/unlock-keyboard-mouse/
https://chromewebstore.google.com/detail/ijngdimmjkngoglcjaheoadciaalbafl
(then you see that default behavior happens: scrolling. unless it is also set with improvedtube)

  • why does this only have 500 users after years? (we can rename it or anything). there is no other browser extension. there is a similar tampermonkey script, with over 2million downloads without an UI: 暂停维护通知 Cat7373/remove-web-limits#129

about shortcuts: #1565

@Rymapo
Copy link

Rymapo commented Dec 19, 2023

I was just coming here to report this. In my attempts to figure out what was going on, I discovered that if the Play/Pause shortcut is unset, then the doubling occurs. If you set it to another key (say "F1") in the Extension, then space bar works as normal.
If the Play/Pause shortcut isn't set to "space", why is it acting like it is?

Possible solution is to locate and remove the segment of code responsible, and just set the Play/Pause shortcut to "space" by default?

@raszpl
Copy link
Contributor

raszpl commented Jun 29, 2024

Space listens for keyup events, thats why it acts weird, fixed in #2421

@raszpl raszpl closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

4 participants