feat: persist caption settings in localStorage on track mode change (code100x#1493) #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/save-caption-settings-to-localstorage
…ave-caption-settings-to-localstorage
devsargam
requested changes
Nov 12, 2024
src/components/VideoPlayer2.tsx
Outdated
| @@ -92,6 +92,52 @@ export const VideoPlayer: FunctionComponent<VideoPlayerProps> = ({ | |||
| return pipButtonContainer; | |||
| }; | |||
|
|
|||
| // Fetch previously saved captions setting from localStorage | |||
There was a problem hiding this comment.
Can you remove this comment?
There was a problem hiding this comment.
i added this comment to help other people understand these line of codes. anyways i'll remove it
| @@ -92,6 +92,52 @@ export const VideoPlayer: FunctionComponent<VideoPlayerProps> = ({ | |||
| return pipButtonContainer; | |||
| }; | |||
|
|
|||
| // Fetch previously saved captions setting from localStorage | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
Why have 2 useEffects with same dependencies array? Can you add the below login in here only?
…ave-caption-settings-to-localstorage
|
hey @devsargam Please check now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#1493)
PR Fixes:
Resolves #1493
Checklist before requesting a review