Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Search Results Container Overflow Issue #1596

Open
designed2code opened this issue Nov 30, 2024 · 7 comments · May be fixed by #1597
Open

bug: Search Results Container Overflow Issue #1596

designed2code opened this issue Nov 30, 2024 · 7 comments · May be fixed by #1597
Labels
bug Something isn't working

Comments

@designed2code
Copy link

Describe the bug
When searching returns multiple results, the results list overflows outside its parent container instead of being contained within it.

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to the search bar after login to the https://app.100xdevs.com/ site
  2. Enter a search term that will return many results (e.g., "mono")
  3. Observe how results extend beyond the container boundaries

Expected behavior

  1. Search results should be contained within the container
  2. A vertical scrollbar should appear when results exceed container height
  3. All results should be accessible by scrolling within the container

Suggested Fix

  1. In the src/components/search/SearchResults.tsx
  2. Add an overflow:auto to the div which is having max-h-[40vh]

Screenshots or GIFs
image

Takeyourdevelopmentskillsfrom0to100andjointhe100xdevscommunity-GoogleChrome2024-11-3022-49-05-ezgif com-video-to-gif-converter
ser-attachments/assets/5372797b-29ca-48a6-bb3f-6663028ad087)

image

Info (please complete the following information):

  • Browser :- Chrome
  • Version 131.0.6778.86

Additional context
Add any other context about the problem here.

@designed2code designed2code added the bug Something isn't working label Nov 30, 2024
@pkmanas22 pkmanas22 linked a pull request Nov 30, 2024 that will close this issue
2 tasks
@anniop
Copy link

anniop commented Dec 2, 2024

if the bug is fixed why the fix is not showing on the website the pr is not merged or what? and if yes please merge it

@designed2code
Copy link
Author

Didn't raise a PR because as per the contributing guidelines "Don't make any pull request for issues you are not assigned to. It will be closed without merging".
https://github.com/code100x/cms/blob/main/CONTRIBUTING.md#dont-while-contributing

@anniop
Copy link

anniop commented Dec 2, 2024

is this issue assigned to someone?
if not assign it to me

@designed2code
Copy link
Author

The maintainer or moderator can assign the issue accordingly.

@anniop
Copy link

anniop commented Dec 2, 2024

okay got it
thanks!!

@pkmanas22
Copy link
Contributor

Didn't raise a PR because as per the contributing guidelines "Don't make any pull request for issues you are not assigned to. It will be closed without merging". https://github.com/code100x/cms/blob/main/CONTRIBUTING.md#dont-while-contributing

Thank you @designed2code for informing. Sorry that I didn't followed the guidelines.

What should I do now, should I close the PR or wait for assign or something else.

@anniop
Copy link

anniop commented Dec 2, 2024

i guess don't close the pr rather ask moderators to assign this task to you or close the pr as soon as the task gets assigned to you then again raise a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants