closes #212 #235
Merged
closes #212 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hkirat had to create a new PR due to computer issues. |
Closed
|
#241 seems to be a duplicate of this issue. @krishhh16 I would recommend you close one of these PRs to not come across as spammy. |
|
Ahh alright, I had to create another one because of a Linting and formatting on PR check was failing, just wanted to see if creating another one that fixes the linting problem fixes the check |
|
@krishhh16 No worries. Feel free to ignore the failing CI PR check for now as it's being resolved in #244 for now. Your changes should still be valid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #212