Feat/bookmarks #245
Merged
Feat/bookmarks #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved bookmark components in their folder added isPineed missed migration by hsingh rearranged bookmark data fetching and view made edit bookmark separate and some finishing touches changed bookmark from timestamp to video
reverted seed.ts css changes
|
@hkirat is this the right solution? If yes, I'll start implementing other features marked as Todo |
|
Looks good |
I was thinking I'll implement all the other todos in the same PR, and make the UI better, or do you want to merge this first and then incrementally make it better? |
|
resolved the conflicts @hkirat |
|
/bounty $75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4 - Feature - Bookmarks.
Screencast.from.2024-03-19.06-07-07.webm
Todo:
@hkirat how does this look to you? There can be a button in the video player or below it as well if needed.