-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: users can now see their watch history #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hkirat could you please review this and the other PR (feat/bookmarks) whenever you get some time |
Great feature, lots of merge conflicts tho (my bad) |
Yes, cleaning them |
Hey @hkirat, fixed the conflicts |
/bounty $125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #250 : Watch History
Uploaded video after changing the code on 24/3/2024:
Screencast.from.2024-03-24.19-47-20_compressed.webm
Added previous year date
PS
Added extra videos to test in local db using seed.ts file. Code for that -> https://gist.github.com/nimit9/b8a06963add1f8e8aef4750e2a7777a0
Used Carousel from shadcn which uses Embla-Carousel library, hence the added dependency in package.json
@hkirat will resolve the Merge Conflicts that might come up once Feat/bookmarks #245 is merged.