Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca un utilizator ANABI, vreau sa vad lista tuturor instantelor de judecata #48

Open
4 tasks done
vlad2 opened this issue Mar 18, 2019 · 7 comments
Open
4 tasks done

Comments

@vlad2
Copy link
Contributor

vlad2 commented Mar 18, 2019

As dori sa pot lista instantele, intr-un tabel asemanator celui care apare cand listez bunurile.

  • Tabelul ar trebui sa fie paginat.

Proprietatile unei instante sunt specificate in
https://codeforromania.atlassian.net/wiki/spaces/ANABI/pages/267256067/Entit+i

Lista instantelor poate fi gasita aici:
http://portal.just.ro/SitePages/Instante.aspx

  • Backend - modificare campuri in DB
  • Backend - populare instante cu lista luata de pe portal.just.ro (Cosmin Popescu)
  • Frontend cu backend mockuit
  • Legat FE de BE (Stefan Oproiu)
@vlad2
Copy link
Contributor Author

vlad2 commented Mar 30, 2019

@vlad2
Copy link
Contributor Author

vlad2 commented Apr 20, 2019

Cosmin Popescu:

La tabelul "Institutions" ar trebui adaugata coloana: BusinessId - integer.

Si trebuie sterse coloanele:

  • CategoryId
  • AddressDbId

Si apoi ar trebui modificat endpointul de list institutions sa intoarca BusinessId-ul, nu ID-ul autogenerat.
Si sa nu mai intoarca categoryId.

Asa intoarce acum:

[
  {
    "id": 1,
    "categoryId": 4,
    "name": "Curtea de Apel Alba Iulia",
    "address": null,
    "contactData": "Some contact here"
  }
]

Asa as vrea sa intoarca:

[
  {
    "id": 57,    // sau businessId 
    "name": "Curtea de Apel Alba Iulia",
    "contactData": "Some contact here"
  }
]

@cosminpopescu14
Copy link

Sa il am la indemana in Slack :)

@vlad2
Copy link
Contributor Author

vlad2 commented May 12, 2019

Hello,

Am testat popularea institutiilor, si sunt urmatoarele lucruri:

  • Cand sterg baza de date, si restartez aplicatia, primesc eroarea:

anabi-gestiune-api_1 | An error occurred seeding the DB.
anabi-gestiune-api_1 | System.IO.FileNotFoundException: Could not find file '/app/..\institutions.json'.
anabi-gestiune-api_1 | File name: '/app/..\institutions.json'
anabi-gestiune-api_1 | at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
anabi-gestiune-api_1 | at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
anabi-gestiune-api_1 | at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
anabi-gestiune-api_1 | at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize)
anabi-gestiune-api_1 | at System.IO.File.OpenText(String path)
anabi-gestiune-api_1 | at Anabi.InstitutionsImporter.InstitutionImporter.Deserialize() in /app/Anabi.InstitutionsImporter/InstitutionImporter.cs:line 18
anabi-gestiune-api_1 | at Anabi.DataAccess.Ef.DbInitializer.AddInstitutions(AnabiContext context) in /app/Anabi.DataAccess.Ef/DbInitializer.cs:line 34
anabi-gestiune-api_1 | at Anabi.DataAccess.Ef.DbInitializer.InitializeFullDb(AnabiContext context) in /app/Anabi.DataAccess.Ef/DbInitializer.cs:line 29
anabi-gestiune-api_1 | at Anabi.Program.Main(String[] args) in /app/Anabi/Program.cs:line 30
anabi-gestiune-api_1 | warn: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[35]

  1. Cand deschid in IDE, nu-mi apare si InstitutionsImporter. Ar trebui sa apara si el (Cred ca nu apare, pentru ca nu e adaugat in Anabi.sln)

  2. Pe server nu se copiaza si fisierul institutions.json - poate ar trebui mutat in Anabi.InstitutionsImporter (si facut punctul 2?)

  3. Chiar daca pun eu manual pe server institutions.json, tot nu-l deschide. Cred ca ar trebui folosit Path.combine si unde e apelul de File.OpenText. Ma rog, de fapt, cred ca n-ar trebui folosit "" in File.OpenText pentru ca \ e separator de directoare doar pe Windows, nu si pe Linux.

@vlad2
Copy link
Contributor Author

vlad2 commented Jul 21, 2019

M-am uitat pe PR-ul de FE, parea f inofensiv, asa ca i-am dat merge.

Am facut build nou, insa nu vad nicaieri un ecran cu lista institutiilor.

Redeschidem.

@RaduCStefanescu
Copy link
Contributor

@RaduCStefanescu verificat pe serverul de deployment

@RaduCStefanescu
Copy link
Contributor

Rezultatul se intoarce ok din baza de date, doar ca datele nu sunt afisate intr-un tabel ci direct JSON dumped in FE. Lasam issue redeschis.

Screenshot 2019-07-27 at 16 26 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants