Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work a little on performance. Concatenate and minify all js and css. #374

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Work a little on performance. Concatenate and minify all js and css. #374

wants to merge 1 commit into from

Conversation

Utwo
Copy link
Member

@Utwo Utwo commented May 23, 2020

Closes #369
Concatenate and minify all css and js files. Load them from local server instead of CDN or external sources.

!!! Deploy script should be changed to reflect this offline-compression

Concerns that still need to be handle:

  • Fontawesome is loading all.js script. A better option would be to load just regular and fontawesome script hosting-fontawesome. Or even a better option would be to just load the svg's in img tag
  • Some Fontawesome icons needs premium plan

@Utwo Utwo changed the title Work a little on performance. Concatenate and minify all js and css f… Work a little on performance. Concatenate and minify all js and css. May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniri aniri Awaiting requested review from aniri aniri is a code owner

@catileptic catileptic Awaiting requested review from catileptic catileptic is a code owner

@costibleotu costibleotu Awaiting requested review from costibleotu costibleotu is a code owner

@RaduCStefanescu RaduCStefanescu Awaiting requested review from RaduCStefanescu

@vtemian vtemian Awaiting requested review from vtemian vtemian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concatenate and minify css/js
1 participant
@Utwo