Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mobilpay modules dependency on pycrypto and pyopenssl #386

Open
aramboi opened this issue Apr 23, 2021 · 5 comments
Open

Remove mobilpay modules dependency on pycrypto and pyopenssl #386

aramboi opened this issue Apr 23, 2021 · 5 comments
Labels

Comments

@aramboi
Copy link
Member

aramboi commented Apr 23, 2021

Change the instances where the mobilpay modules located here https://github.com/code4romania/covid-19-ro-help/tree/develop/ro_help/mobilpay/mobilpay are using the pycrypto library.

PyCrypto has not been updated since 2013 and it is not tested with Python>3.3. pyOpenSSL also recommends not using it for anything other than making a TLS connection.

We should use https://github.com/pyca/cryptography instead as this is the recommended library to use for crypto primitives in this day and age.

@aramboi aramboi changed the title Remove mobilpay utility modules dependency on pycrypto and pyopenssl Remove mobilpay modules dependency on pycrypto and pyopenssl Apr 23, 2021
@vamposdecampos
Copy link

Taking a look, but anyone, feel free to beat me to it.
I find your lack of unit tests... disturbing.

@aramboi
Copy link
Member Author

aramboi commented Apr 26, 2021

Thanks for the PR @vamposdecampos. I think the direction you set is the right way to go about this. First we need to add some unit tests to the main apis the module exposes, especially the ones that use pycrypto which we are trying to replace. Then do a separate PR for the actual replacement and make sure those tests pass and we don't introduce any regressions in the current workflow.

@calindragomir
Copy link

@aramboi , what's the status here? do you need help ?

@catileptic
Copy link
Member

@calindragomir, if you would care to work on this, go ahead :)

@vitaliel
Copy link

vitaliel commented Nov 4, 2021

Hello,

Switching to pyca/cryptography will add an iceberg to building process, because for some reasons maintainers decided to rely on rust that needs few Gb to build.

If pycrypto and pyopenssl works, I would continue to use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants