add one more test

Signed-off-by: alex boten <[email protected]>

Author: codeboten

otelconf/log.go

@@ -23,10 +23,10 @@ import (
 )
 
 func loggerProvider(cfg configOptions, res *resource.Resource) (log.LoggerProvider, shutdownFunc, error) {
-	provider, ok := cfg.opentelemetryConfig.LoggerProvider.(*LoggerProviderJson)
-	if provider == nil {
+	if cfg.opentelemetryConfig.LoggerProvider == nil {
 		return noop.NewLoggerProvider(), noopShutdown, nil
 	}
+	provider, ok := cfg.opentelemetryConfig.LoggerProvider.(*LoggerProviderJson)
 	if !ok {
 		return noop.NewLoggerProvider(), noopShutdown, newErrInvalid("logger_provider")
 	}

otelconf/log_test.go

@@ -46,6 +46,18 @@ func TestLoggerProvider(t *testing.T) {
 			name:         "no-logger-provider-configured",
 			wantProvider: noop.NewLoggerProvider(),
 		},
+		{
+			name: "invalid-provider",
+			cfg: configOptions{
+				opentelemetryConfig: OpenTelemetryConfiguration{
+					LoggerProvider: &MeterProviderJson{
+						Readers: []MetricReader{},
+					},
+				},
+			},
+			wantProvider: noop.NewLoggerProvider(),
+			wantErr:      newErrInvalid("logger_provider"),
+		},
 		{
 			name: "error-in-config",
 			cfg: configOptions{
@@ -65,10 +77,12 @@ func TestLoggerProvider(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		mp, shutdown, err := loggerProvider(tt.cfg, resource.Default())
-		require.Equal(t, tt.wantProvider, mp)
-		assert.ErrorIs(t, err, tt.wantErr)
-		require.NoError(t, shutdown(t.Context()))
+		t.Run(tt.name, func(t *testing.T) {
+			mp, shutdown, err := loggerProvider(tt.cfg, resource.Default())
+			require.Equal(t, tt.wantProvider, mp)
+			assert.ErrorIs(t, err, tt.wantErr)
+			require.NoError(t, shutdown(t.Context()))
+		})
 	}
 }