Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate limit problem of the render action #121

Open
nuest opened this issue Oct 9, 2024 · 0 comments
Open

Fix rate limit problem of the render action #121

nuest opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
development Development of the register

Comments

@nuest
Copy link
Member

nuest commented Oct 9, 2024

See https://github.com/codecheckers/register/actions/runs/11251093376/job/31281384845


https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api says

The primary rate limit for unauthenticated requests is 60 requests per hour.

So that is way to little.

You can use a personal access token to make API requests. Additionally, you can authorize a GitHub App or OAuth app, which can then make API requests on your behalf.
All of these requests count towards your personal rate limit of 5,000 requests per hour.

That should be fine.

For the same reason, I cannot even render the register locally anymore using the Docker image, i.e., make image_render in.

https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow seems to have a suitable solution for the GitHub Action. From the previous link:

You can use the built-in GITHUB_TOKEN to authenticate requests in GitHub Actions workflows. See "Automatic token authentication."
The rate limit for GITHUB_TOKEN is 1,000 requests per hour per repository.

We also need documentation on using a token for the local rendering then with the image.

@nuest nuest added this to the CHECK-NL end of project milestone Oct 9, 2024
@nuest nuest self-assigned this Oct 9, 2024
nuest added a commit to nuest/register that referenced this issue Oct 9, 2024
@nuest nuest added the development Development of the register label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Development of the register
Projects
None yet
Development

No branches or pull requests

1 participant