Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a map breaks mine doors and entrances #5

Open
bdew opened this issue May 12, 2017 · 1 comment
Open

Saving a map breaks mine doors and entrances #5

bdew opened this issue May 12, 2017 · 1 comment
Assignees
Labels

Comments

@bdew
Copy link

bdew commented May 12, 2017

Problem is in this code:

https://github.com/codeclubab/WurmModServerApi/blob/master/src/main/java/com/wurmonline/wurmapi/api/MapData.java#L777-L789

Should probably add a check that the tile in question isn't a mine door or hole.

@keenan-v1
Copy link
Contributor

It does look like this is indeed the issue. As far as I can see, that code is trying to determine places where rock would be exposed, and if it's not rock, make it rock.

I think it would also be prudent to grab the cave data and check for a cave entrance. This way if anything were to happen where a tile was inadvertently set to "hole" or "mine door" without said cave behind it, it will automatically be fixed on save.

@keenan-v1 keenan-v1 self-assigned this May 22, 2017
@keenan-v1 keenan-v1 added the bug label May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants