-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to clarify what versions of JavaScript are supported #13
Comments
It's ES5 strict mode with some parts of ES6 implemented, and some parts of non-strict mode implemented. (And possibly some parts of ES5 missing). Any thoughts on the best way to explain this? |
It seems that class inheritance in ES6 is not supported. |
It should be, atleast to some degree. See https://github.com/codecombat/esper.js/blob/master/contrib/test-suites/js-corpus/classes.js What's not working for you? |
|
Is it easy to improve esper.js to support the example above? |
Should be easy enough. The bug here is that the Cat class doesn't inherit the constructor from Animal. For example the below works.
|
@ngocdaothanh Fixed in 6a2797b |
Please update README to clarify what versions of JavaScript are supported.
The text was updated successfully, but these errors were encountered: