From 6bc38a9739eecb9033fead077484794548afe90c Mon Sep 17 00:00:00 2001 From: Arpad Borsos Date: Mon, 18 Nov 2024 13:29:33 +0100 Subject: [PATCH] Clean up unused `minio.periodic_callback_ms` field --- shared/validation/install.py | 1 - tests/conftest.py | 1 - tests/unit/test_config.py | 2 -- tests/unit/validation/test_install_validation.py | 2 -- 4 files changed, 6 deletions(-) diff --git a/shared/validation/install.py b/shared/validation/install.py index 3a12e68a4..135c1cd50 100644 --- a/shared/validation/install.py +++ b/shared/validation/install.py @@ -270,7 +270,6 @@ def check_task_config_key(field, value, error): "bucket": {"type": "string"}, "region": {"type": "string"}, "expire_raw_after_n_days": {"type": "boolean"}, - "periodic_callback_ms": {"type": ("boolean", "integer")}, "verify_ssl": {"type": "boolean"}, }, }, diff --git a/tests/conftest.py b/tests/conftest.py index bd022ed85..e150728c9 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -25,7 +25,6 @@ def mock_configuration(mocker): "access_key_id": "codecov-default-key", "bucket": "archive", "hash_key": "88f572f4726e4971827415efa8867978", - "periodic_callback_ms": False, "secret_access_key": "codecov-default-secret", "verify_ssl": False, }, diff --git a/tests/unit/test_config.py b/tests/unit/test_config.py index f88b4d8c2..da47a9836 100644 --- a/tests/unit/test_config.py +++ b/tests/unit/test_config.py @@ -73,7 +73,6 @@ def test_get_config_production_use_case(self, mocker): "services:", " minio:", " bucket: codecov", - " periodic_callback_ms: false", " sentry:", " server_dsn: server_dsn", " google_analytics_key: UA-google_analytics_key-1", @@ -184,7 +183,6 @@ def test_get_config_case_with_more_nested_types(self, mocker): "services:", " minio:", " bucket: codecov", - " periodic_callback_ms: false", " sentry:", " server_dsn: server_dsn", " google_analytics_key: UA-google_analytics_key-1", diff --git a/tests/unit/validation/test_install_validation.py b/tests/unit/validation/test_install_validation.py index 9888645cd..44e4707f1 100644 --- a/tests/unit/validation/test_install_validation.py +++ b/tests/unit/validation/test_install_validation.py @@ -89,7 +89,6 @@ def test_validate_sample_production_config(mocker): "iam_endpoint": None, "hash_key": "aabb72b4a26e49a1a2a41bebaaa6a9aa", "bucket": "codecov", - "periodic_callback_ms": False, }, "google_analytics_key": "UA-63027104-1", "chosen_storage": "gcp", @@ -219,7 +218,6 @@ def test_validate_sample_production_config(mocker): "iam_endpoint": None, "hash_key": "aabb72b4a26e49a1a2a41bebaaa6a9aa", "bucket": "codecov", - "periodic_callback_ms": False, }, "google_analytics_key": "UA-63027104-1", "chosen_storage": "gcp",