Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect result (submitted data mis-interpreted; not a data problem) #7

Open
jimcraner opened this issue Aug 6, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@jimcraner
Copy link

I submitted several test requests and got proper responses.

When I submitted "Peoria, IL" (no quotes), the returned result was:

In Prole, Iowa you are on Iowa land.

I tried the same request multiple times and always got the Prole, IA result.

For reference, "Peoria Heights, IL" (no quotes) did correctly return Peoria Heights and its associated land data.

To Reproduce:

  1. Submit Peoria, IL as a city to the land_acknowledgement test number
  2. Note result.

(BTW, this is a very awesome project, thanks to all of the contributors and participants!! :-)

@mark-meyer
Copy link
Member

This is an interesting case where the megaphone-based fuzzy matching fails. The megaphones of PEORIAIL PROLEIA are a match.

postgres=# select metaphone('PEORIAIL', 10);
 metaphone
-----------
 PRL
(1 row)

postgres=# select metaphone('PROLEIA', 10);
 metaphone
-----------
 PRL
(1 row)

This is currently fixed by temporarily disabling fuzzy matching, but a better alternative would be to find a way to prefer exact matches or look for exact matches and only look for a fuzzy match if that fails.

@mark-meyer mark-meyer added the bug Something isn't working label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants