Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse Report: Improve Performance, accessibility and best practices #45

Open
2 of 25 tasks
ychoy opened this issue Jan 14, 2020 · 0 comments
Open
2 of 25 tasks

Comments

@ychoy
Copy link
Contributor

ychoy commented Jan 14, 2020

Performance

  • Eliminate render-blocking resources
  • Preconnect to required origins
  • Properly size images
  • Serve images in next-gen formats
  • Ensure text remains visible during webfont load
  • Serve static assets with an efficient cache policy
  • Minimize main-thread work
  • Avoid chaining critical requests
  • Keep request counts low and transfer sizes small

Best Practices

  • Links to cross-origin destinations are unsafe
  • Browser errors were logged to the console
  • Add favicon

Accessibility

  • Background and foreground colors do not have a sufficient contrast ratio.
  • or <iframe> elements do not have a title

Manually check these for a11y:

  • The page has a logical tab order
  • Interactive controls are keyboard focusable
  • Interactive elements indicate their true purpose and state
  • The user's focus is directed to new content added to the page
  • User focus is not accidentally trapped in a region
  • Custom controls have associated labels
  • Custom controls have ARIA roles
  • Visual order on the page follows DOM order
  • Offscreen content is hidden from assistive technology
  • Headings don't skip levels
  • HTML5 landmark elements are used to improve navigation
ychoy added a commit that referenced this issue Jan 15, 2020
ychoy added a commit that referenced this issue Jan 15, 2020
…prevent security vulnerabilities. Addresses issue #45
ychoy added a commit that referenced this issue Jan 15, 2020
ychoy added a commit that referenced this issue Jan 15, 2020
…prevent security vulnerabilities. Addresses issue #45
ychoy added a commit that referenced this issue Jan 15, 2020
…prevent security vulnerabilities; update heading levels to address accessibility issue #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant