Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Overqualified CSS Selectors for Component CSS Modules #86

Open
sunnymui opened this issue Sep 21, 2019 · 0 comments
Open

Cleanup Overqualified CSS Selectors for Component CSS Modules #86

sunnymui opened this issue Sep 21, 2019 · 0 comments

Comments

@sunnymui
Copy link
Contributor

Some of the components have overqualified CSS selectors. So far I've seen things go 4-5 levels deep i.e.

.container .subcontainer .someblock .someelement input or similar, you get the idea

This is pretty unwieldy and can be especially hard to work around when styling things. It also makes it harder to scale/maintain. We should minimize the levels of qualifying in CSS selectors by reducing it to the bare minimum.

Alternatively, we could also look into some other solutions for managing the CSS in React:
https://blog.bitsrc.io/5-ways-to-style-react-components-in-2019-30f1ccc2b5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant