Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken images #101

Open
2 tasks
ychoy opened this issue May 29, 2020 · 3 comments
Open
2 tasks

Broken images #101

ychoy opened this issue May 29, 2020 · 3 comments
Assignees
@kgudger

Comments

@ychoy
Copy link
Collaborator

ychoy commented May 29, 2020

Some images are broken, and it might be a result of the web scraper breaking. Needs investigation.

Checklist:

  • Fix broken images
  • Add a placeholder image in case in the future the image URL is incorrect
@kgudger
Copy link
Collaborator

kgudger commented May 29, 2020

It seems images that start with "https://sanjoseca.gov/ImageRepository/Path?" are not loading, I'm guessing San Jose moved them on their site? Is it that simple :-)

@kgudger
Copy link
Collaborator

kgudger commented May 31, 2020

I cleaned up all of the sanjoseca.gov links, let me know when I can create a pull request. The last 22 links are here: https://docs.google.com/spreadsheets/d/1tXs3rvfX73brIidlStG1sO-QlpIzyvYithssRQBNVz8/edit?usp=sharing
Let me know if you want me to fix them.

@ychoy
Copy link
Collaborator Author

ychoy commented Jun 1, 2020

Yes, thank you! Let me know when your PR is ready for review.

@kgudger kgudger mentioned this issue Jun 11, 2020
Merged
ychoy pushed a commit that referenced this issue Jun 11, 2020
@kgudger
Fix broken images from the City of San Jose scraper (#102)
9978a4f 
* Updated a number of image links in artworks-overrides.json to fix breaks.
* Cleaned up all broken links, removing those without any found images.
* Addresses issue #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgudger kgudger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgudger @ychoy