Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: implement Double Opt-In #98

Open
jeffersonken19 opened this issue Jan 13, 2021 · 4 comments
Open

Server: implement Double Opt-In #98

jeffersonken19 opened this issue Jan 13, 2021 · 4 comments
Labels
High Priority High Priority

Comments

@jeffersonken19
Copy link
Collaborator

No description provided.

@sent-hil
Copy link
Collaborator

sent-hil commented Jan 15, 2021

Hello, I did some more research on the double opt-in, and here are my findings:

  • Twilio supports automatic opt-out on any SMS if the user replies "STOP". Below is an example:
    image

  • Twilio supports opt-in/opt-out on the phone number level. Therefore, we can't have them subscribe to a single meeting notification while unsubscribing to another one from within the SMS. They can of course do so from the app itself.

  • Regarding email opt-in, it would be best to follow the same semantics as SMS. The first time you subscribe with an email you are sent an opt-in email and once the email is confirmed you can subscribe to any number of subsequent meetings without further opt-in requirements. In every email, there will be an opt-out link which just like SMS is a permanent mute switch.

  • A more secure route is to remove guest notification and make everyone authenticate with email and password and we again do a one time opt-in email. This might be overkill for V1.

This is related to the #97 which is what I'm working on right now. Regardless of the approach, this current task should be blocked till the linked one is complete.

@sent-hil sent-hil self-assigned this Jan 22, 2021
@jeffersonken19 jeffersonken19 added the High Priority High Priority label Jan 27, 2021
@OSSJSharedAdmin
Copy link
Contributor

This just needs to be plugged into authentication

@sent-hil sent-hil removed their assignment May 16, 2021
@errorsurface
Copy link
Collaborator

errorsurface commented Nov 18, 2022

@JMStudiosJoe Would like to assign this issue to @dnahol

@dnahol
Copy link
Contributor

dnahol commented Jan 13, 2023

Just started working on this.

This and other two linked issues say SMS and email notifications for agenda items were working back then (2021).

Tried testing that on my local instance today. Was able to create test meeting, but wasn't able to upload the example.csv agenda mentioned in the README under Architecture. When I try, the frontend instance just hangs:

"
Upload is its own express app and can be found in backend/agenda_upload_service/. The upload services will be brought up by docker-compose along with the other services. To upload, use the example file (backend/agenda_upload_service/example.csv), then do:

curl --form csvfile='@backend/agenda_upload_service/example.csv' -F csvfile=example.csv localhost:3002/upload
"

I'll bring this up at the meeting today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority High Priority
Projects
None yet
Development

No branches or pull requests

5 participants